Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LIMIT and ORDER BY clauses in Values clauses #2590

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #2475

Are there any other side effects of this change that we should be aware of?

Redefined the Postgres Values clause to be more like Spark3 - which changes some of the YAML parse trees.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2590 (bac493f) into main (88df89f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2590   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11886     11902   +16     
=========================================
+ Hits         11886     11902   +16     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_spark3.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88df89f...bac493f. Read the comment docs.

@tunetheweb tunetheweb merged commit 2222890 into sqlfluff:main Feb 9, 2022
@tunetheweb tunetheweb deleted the values-limits-orderby branch February 9, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIMIT and ORDER BY for VALUES clauses in spark3
2 participants