Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite Support more CREATE TRIGGER options #2594

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Feb 9, 2022

Brief summary of the change made

Makes progress on #1846

Are there any other side effects of this change that we should be aware of?

Altered the ANSI version rather than creating a new clone as ANSI version looked too strict to me.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2594 (900fb3f) into main (3ec9e23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2594   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11902     11902           
=========================================
  Hits         11902     11902           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec9e23...900fb3f. Read the comment docs.

@tunetheweb tunetheweb merged commit 76501bf into sqlfluff:main Feb 9, 2022
@tunetheweb tunetheweb deleted the sqlite-create-trigger branch February 10, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants