-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wildcards in triggers #2597
Support wildcards in triggers #2597
Conversation
Several L047 tests are failing. |
Yeah, gonna go with a different, less drastic, approach here. As fixing L047 to handle this new wildcard syntax looks a bit more difficult. |
I see that this change makes the parse tree deeper. 👍🏽 |
…eb/sqlfluff into support-wildcard-in-expressions
Not anymore! This should all work now. |
Codecov Report
@@ Coverage Diff @@
## main #2597 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 11902 11902
=========================================
Hits 11902 11902
Continue to review full report at Codecov.
|
Good to review now @barrywhart |
Brief summary of the change made
Fixes #1831
Are there any other side effects of this change that we should be aware of?
Causes a number of other Yamls to (correctly!) now classify
*
as wildcard expression so looks like more changes than it really is.Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.