Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Support expressions in arrays #2599

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #2036

Are there any other side effects of this change that we should be aware of?

Not sure why Postgres overrode the ansi definition. It says it was to allow nested arrays, but they are supported with ANSI. Looks like @WittierDinosaur added this in #1722 but I don't think it's necessary.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #2599 (652cbb3) into main (4590bff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11902     11894    -8     
=========================================
- Hits         11902     11894    -8     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_postgres.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4590bff...652cbb3. Read the comment docs.

@tunetheweb tunetheweb merged commit 14e80e5 into sqlfluff:main Feb 10, 2022
@tunetheweb tunetheweb deleted the column-arrays branch February 10, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL: ARRAY not parsed
2 participants