Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support indenting WINDOWS clauses and (optionally) CTEs #2601

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #2600

Are there any other side effects of this change that we should be aware of?

WINDOWS clauses will now indent (similar to other main clauses) which may cause some extra rules to flag for those that don't indent them.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #2601 (f16c1bd) into main (14e80e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2601   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        11894     11894           
=========================================
  Hits         11894     11894           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_tsql.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e80e5...f16c1bd. Read the comment docs.

@elyobo
Copy link
Contributor

elyobo commented Feb 10, 2022

Tested your branch and confirmed it's looking good, thank you very much for this.

@tunetheweb tunetheweb merged commit 7d3ec24 into sqlfluff:main Feb 10, 2022
@tunetheweb tunetheweb deleted the more-indentation-options branch February 10, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: consisitent indentation styles between blocks
3 participants