L046: Detect Jinja spacing issues where segment begins with literal content #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrywhart
commented
Feb 10, 2022
| @@ -52,37 +53,41 @@ def _get_whitespace_ends(s: str) -> Tuple[str, str, str]: | |||
|
|
|||
| def _eval(self, context: RuleContext) -> LintResult: | |||
| """Look for non-literal segments.""" | |||
| if not context.segment.pos_marker.is_literal(): | |||
| if context.segment.is_raw() and not context.segment.pos_marker.is_literal(): | |||
There was a problem hiding this comment.
You want to review this with "Hide whitespace" enabled.
barrywhart
commented
Feb 10, 2022
| rsp.is_slice_type("templated") | ||
| ) | ||
| for raw_slice in templated_raw_slices: | ||
| src_raw = raw_slice.raw |
There was a problem hiding this comment.
Old code: Assumed that segments would be 100% templated code.
New code: Uses Segments.raw_slices to identify and individually process the raw, templated slices that make up the segment.
tunetheweb
approved these changes
Feb 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #2603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 11894 11896 +2
=========================================
+ Hits 11894 11896 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #1296
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.