Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSQL: Fix SET TRANSACTION ISOLATION LEVEL parsing #2701

Merged
merged 1 commit into from Feb 27, 2022

Conversation

jpers36
Copy link
Contributor

@jpers36 jpers36 commented Feb 21, 2022

Brief summary of the change made

SQLFluff's TSQL dialect does not parse SET TRANSACTION ISOLATION LEVEL statements correctly. This PR will fix it.

Are there any other side effects of this change that we should be aware of?

None.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #2701 (359e4dd) into main (244c3d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2701   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12060     12060           
=========================================
  Hits         12060     12060           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_tsql.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_tsql_keywords.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244c3d5...359e4dd. Read the comment docs.

@tunetheweb tunetheweb merged commit d1cc947 into sqlfluff:main Feb 27, 2022
@tunetheweb tunetheweb changed the title TSQL: Fix SET TRANSACTION ISOLATION LEVEL parsing TSQL: Fix SET TRANSACTION ISOLATION LEVEL parsing Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants