Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark3: test cases for Table-Valued Functions #2703

Merged
merged 2 commits into from Feb 27, 2022

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Feb 22, 2022

Brief summary of the change made

This PR adds test cases for Table-Valued Functions

Are there any other side effects of this change that we should be aware of?

N/A

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2703 (269c06e) into main (d2cdbd6) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #2703      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files         163       163              
  Lines       12041     12060      +19     
===========================================
+ Hits        12035     12060      +25     
+ Misses          6         0       -6     
Impacted Files Coverage Δ
src/sqlfluff/rules/L003.py 100.00% <0.00%> (ø)
src/sqlfluff/rules/L004.py 100.00% <0.00%> (ø)
src/sqlfluff/rules/L016.py 100.00% <0.00%> (ø)
src/sqlfluff/core/parser/lexer.py 100.00% <0.00%> (ø)
src/sqlfluff/core/templaters/base.py 100.00% <0.00%> (ø)
src/sqlfluff/core/parser/grammar/base.py 100.00% <0.00%> (ø)
src/sqlfluff/core/parser/grammar/anyof.py 100.00% <0.00%> (ø)
src/sqlfluff/core/parser/segments/base.py 100.00% <0.00%> (ø)
src/sqlfluff/core/parser/grammar/greedy.py 100.00% <0.00%> (ø)
src/sqlfluff/core/parser/grammar/sequence.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2cdbd6...269c06e. Read the comment docs.

@tunetheweb tunetheweb merged commit cce8d55 into sqlfluff:main Feb 27, 2022
@R7L208 R7L208 deleted the r7l208/spark3-table-valued-function branch August 30, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants