L018: Move closing parenthesis to next line #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrywhart
commented
Feb 27, 2022
| expanding=["common_table_expression", "bracketed"], | ||
| pass_through=True, | ||
| ) | ||
| for elem in context.segment.raw_segments |
There was a problem hiding this comment.
This is a fascinating bug. Apparently, the rule was designed to handle this case, but:
- There was no test for it.
- It didn't work.
- Apparently, the
else:block starting on line 134 was never executing. At least, not in any of theL018.ymltest cases.
Codecov Report
@@ Coverage Diff @@
## main #2734 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 12061 12061
=========================================
Hits 12061 12061
Continue to review full report at Codecov.
|
tunetheweb
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #2713
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.