Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for load_macros_from_path #2743

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented Feb 28, 2022

Brief summary of the change made

Fixes #2740. (It wasn't actually a bug, but it did seem that the documentation could be better.)

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #2743 (b0ca73e) into main (8e37b09) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12109     12109           
=========================================
  Hits         12109     12109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e37b09...b0ca73e. Read the comment docs.

@barrywhart barrywhart merged commit a9bc45e into sqlfluff:main Feb 28, 2022
@tunetheweb tunetheweb changed the title Improve docs for "load_macros_from_path" Improve docs for load_macros_from_path Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_macros_from_path doesn't work with filenames, only with directory names.
2 participants