Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark3: Support for EXPLAIN statement #2767

Merged
merged 3 commits into from Mar 2, 2022

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Mar 2, 2022

Brief summary of the change made

Replace ExplainStatementSegment from ANSI to allow for additional parameters and an expanded list of explainable statements.

Are there any other side effects of this change that we should be aware of?

Removed parse_grammar from ExplainStatementSegment in ANSI and re-assigned parse_grammar to match_grammar in Postgres and Snowflake dialects.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #2767 (d3a0d35) into main (fa249a9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2767   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12206     12209    +3     
=========================================
+ Hits         12206     12209    +3     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_spark3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa249a9...d3a0d35. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

src/sqlfluff/dialects/dialect_spark3.py Outdated Show resolved Hide resolved
src/sqlfluff/dialects/dialect_spark3.py Outdated Show resolved Hide resolved
src/sqlfluff/dialects/dialect_spark3.py Outdated Show resolved Hide resolved
@R7L208
Copy link
Contributor Author

R7L208 commented Mar 2, 2022

Updated PR description to reflect most recent change of removing parse_grammar from ExplainStatementSegment

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those changes!

@tunetheweb tunetheweb merged commit 99761d2 into sqlfluff:main Mar 2, 2022
@R7L208 R7L208 deleted the r7l208/spark3-explain-statement-1 branch August 30, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants