Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: L036 corrupts SELECT DISTINCT id query #2768

Merged

Conversation

barrywhart
Copy link
Member

@barrywhart barrywhart commented Mar 2, 2022

Brief summary of the change made

Fixes #2765

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@barrywhart barrywhart marked this pull request as draft March 2, 2022 20:56
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #2768 (a92cf44) into main (d016fef) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12213     12214    +1     
=========================================
+ Hits         12213     12214    +1     
Impacted Files Coverage Δ
src/sqlfluff/rules/L036.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d016fef...a92cf44. Read the comment docs.

@barrywhart barrywhart marked this pull request as ready for review March 2, 2022 21:14
@tunetheweb tunetheweb merged commit 251f223 into sqlfluff:main Mar 2, 2022
@tunetheweb tunetheweb changed the title Bug fix: L036 corrupts "SELECT DISTINCT id" query Bug fix: L036 corrupts SELECT DISTINCT id query Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"sqlfluff fix --rules L036" corrupts "SELECT DISTINCT ID" query
2 participants