Snowflake: Add dollar quoted string literal #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpy-git
commented
Mar 2, 2022
Comment on lines
-123
to
-129
| DoubleQuotedLiteralSegment=NamedParser( | ||
| "double_quote", | ||
| CodeSegment, | ||
| name="quoted_literal", | ||
| type="literal", | ||
| trim_chars=('"',), | ||
| ), |
There was a problem hiding this comment.
This isn't part of Snowflake and isn't used anywhere in the dialect so cleaning up.
| @@ -505,7 +513,7 @@ class FunctionDefinitionGrammar(BaseSegment): | |||
| type = "function_definition" | |||
| match_grammar = Sequence( | |||
| "AS", | |||
| OneOf(Ref("QuotedLiteralSegment"), Ref("DollarQuotedLiteralSegment")), | |||
There was a problem hiding this comment.
DollarQuotedLiteralSegment isn't anywhere else in the code base. We used to have it in Postgres, but was since combined with QuotedLiteralSegment to simplify the dialect. This is probably just a holdover from when Snowflake inherited from Postgres.
Codecov Report
@@ Coverage Diff @@
## main #2770 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 12214 12214
=========================================
Hits 12214 12214
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Snowflake allows dollar quoted string literals (similar to postgres but no tags). I've updated
QuotedLiteralSegmentto allow these and keep consistent with the postgres approach.Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.