Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: Complete LIMIT grammar #2784

Merged
merged 9 commits into from Mar 4, 2022
Merged

Snowflake: Complete LIMIT grammar #2784

merged 9 commits into from Mar 4, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 4, 2022

Brief summary of the change made

Adds complete LIMIT/FETCH grammar as per the Snowflake docs.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #2784 (d958f86) into main (267b6bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2784   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12264     12286   +22     
=========================================
+ Hits         12264     12286   +22     
Impacted Files Coverage Δ
...rc/sqlfluff/dialects/dialect_snowflake_keywords.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267b6bb...d958f86. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few small nits and comments.

src/sqlfluff/dialects/dialect_snowflake.py Outdated Show resolved Hide resolved
src/sqlfluff/dialects/dialect_snowflake.py Outdated Show resolved Hide resolved
src/sqlfluff/dialects/dialect_snowflake.py Outdated Show resolved Hide resolved
@jpy-git jpy-git merged commit 9f1c7fe into sqlfluff:main Mar 4, 2022
@jpy-git jpy-git deleted the snowflake_limit_clause branch March 4, 2022 15:51
@tunetheweb tunetheweb changed the title Snowflake: Complete LIMIT grammar Snowflake: Complete LIMIT grammar Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants