New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent exceptions when running fix
on dialect fixtures
#2818
Merged
tunetheweb
merged 14 commits into
sqlfluff:main
from
tunetheweb:prevent-itteration-error-in-get_select_statement_info
Mar 9, 2022
+89
−42
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9b04538
Prevent iiteration error in get_select_statement_info
tunetheweb 1e9a638
Add some extra guards
tunetheweb 7b7c94b
Better if
tunetheweb f754e88
Even better if
tunetheweb 6bad08a
Merge branch 'main' into prevent-itteration-error-in-get_select_state…
tunetheweb 5fc5e05
Indentation
tunetheweb 8cae273
Merge branch 'main' into prevent-itteration-error-in-get_select_state…
tunetheweb 674d7fc
Review feedback
tunetheweb d5ee8fb
Add test cases
tunetheweb 7777352
Change test from lint to fix
tunetheweb b35a846
Add types
tunetheweb e0ced71
Coverage
tunetheweb 0187671
Typo
tunetheweb e822b79
Merge branch 'main' into prevent-itteration-error-in-get_select_state…
tunetheweb File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review this bit hiding whitespace: