Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery - prevent L006 flagging hyphenated table references #2842

Merged

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #2771

Are there any other side effects of this change that we should be aware of?

Nope.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@tunetheweb tunetheweb changed the title BigQuery - avoid L006 being raise on hyphenated table references BigQuery - prevent L006 flagging hyphenated table references Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #2842 (27f9671) into main (bdd8dde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2842   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines        12417     12417           
=========================================
  Hits         12417     12417           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd8dde...27f9671. Read the comment docs.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tunetheweb tunetheweb merged commit b44851f into sqlfluff:main Mar 11, 2022
@tunetheweb tunetheweb deleted the 2771-better-bigquery-hyphenation-objects branch June 23, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLFluff improperly parses unquoted Bigquery project names with dashes
2 participants