Reduce unnecessary setting run ci #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In job `python-version-tests`, we already told the version we setup in step `Set up Python`, so we could simply run command `tox -e py` to trigger the job, so we could remove the `Set Tox Python Param` step * In job `other-tests` we just set unused vairable by one step and I think we should directly remove it.
Codecov Report
@@ Coverage Diff @@
## main #2847 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 12425 12425
=========================================
Hits 12425 12425 Continue to review full report at Codecov.
|
|
CI pass and it look good, PTAL @tunetheweb @barrywhart |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-version-tests, we already told the version wesetup in step
Set up Python, so we could simply run commandtox -e pyto trigger the job, so we could remove theSet Tox Python Paramstepother-testswe just set an unused variable by one stepand I think we should directly remove it.