New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JinjaTracer: Split into two classes, break up _slice_template()
function
#2870
Merged
barrywhart
merged 18 commits into
sqlfluff:main
from
barrywhart:bhart-jinja_tracer_tidying
Mar 16, 2022
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
048e10a
Minor cleanup/refactor of JinjaTracer
212a885
More refactoring
e562925
More refactoring
8f4ec6f
More refactoring
e68510f
Add more type annotations
89de547
Extract a function track_block_end() out of update_next_slice_indices()
b18c6a7
Make some functions static
dc15b3f
Split up _slice_template() some more
2170fb6
More types and tidying
fd1e552
RawSliceInfo: Provide default value for next_slice_indices
4129044
Use RawSliceInfo instance instead of alt_id/alt_code variables
9171712
Split JinjaTracer into two classes: JinjaAnalyzer and JinjaTracer
a642326
Make idx a field, rename as idx_raw
5bdc8a8
Tidying
aadd5e8
PR review
0cd54db
PR review
b324f59
Add explanatory comment about str_buff and str_parts
e9f9aa3
Merge branch 'main' into bhart-jinja_tracer_tidying
barrywhart File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to the rest of the PR, but I noticed we were missing this