Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSQL: allow leading GO #2997

Merged
merged 2 commits into from Apr 4, 2022

Conversation

pguyot
Copy link
Contributor

@pguyot pguyot commented Apr 4, 2022

Brief summary of the change made

T-SQL files may start with a leading GO

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #2997 (9c59b86) into main (939113e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #2997   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines        11987     11987           
=========================================
  Hits         11987     11987           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_tsql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939113e...9c59b86. Read the comment docs.

@tunetheweb
Copy link
Member

Couple of questions:

  1. Does it support trailing GOs?
  2. Does it support multiple GOs in the middle of a file?
  3. Depending on 1 end 2 above, would it be better fix to say BatchDelimiterGrammar (Without any other statement) is a permissible statement type in TSQL rather than adding this directly to FileSegment?

@pguyot
Copy link
Contributor Author

pguyot commented Apr 4, 2022

Not sure about what is best for your point 3. The change still supports trailing GOs and multiple GOs in the middle of a file as shown by the test fixture.

@tunetheweb
Copy link
Member

OK Let’s leave as is.

@tunetheweb tunetheweb merged commit ae7b629 into sqlfluff:main Apr 4, 2022
@pguyot pguyot deleted the w14-tsql-allow-for-leading-go branch April 5, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants