Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Support SAFE functions #3048

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #3047

Are there any other side effects of this change that we should be aware of?

Shouldn't be

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@tunetheweb tunetheweb changed the title BigQuery: Support SAFE functions BigQuery: Support SAFE functions Apr 8, 2022
@@ -452,75 +452,82 @@ class FunctionSegment(ansi.FunctionSegment):
for our purposes.
"""

match_grammar = OneOf(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review this with whitespace off

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #3048 (7f031b0) into main (3c47c45) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3048   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines        12057     12057           
=========================================
  Hits         12057     12057           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_bigquery_keywords.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c47c45...7f031b0. Read the comment docs.

@tunetheweb tunetheweb merged commit deb58ef into sqlfluff:main Apr 8, 2022
@tunetheweb tunetheweb deleted the bigquery-safe-function-support branch April 9, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for SAFE. prefix in function calls w.r.t L014
2 participants