Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: REMOVE statement enhancement #3191

Merged

Conversation

jmc-bbk
Copy link
Contributor

@jmc-bbk jmc-bbk commented Apr 26, 2022

Brief summary of the change made

Resolves #3183.

Added support for variables in remove statements [Snowflake].

Are there any other side effects of this change that we should be aware of?

Not that I'm aware of.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3191 (af81c9e) into main (8f148de) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          166       166           
  Lines        12346     12346           
=========================================
  Hits         12346     12346           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f148de...af81c9e. Read the comment docs.

@tunetheweb tunetheweb merged commit ca522e1 into sqlfluff:main Apr 26, 2022
@tunetheweb tunetheweb changed the title Snowflake remove statement enhancement Snowflake: REMOVE statement enhancement Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake: RemoveStatementSegment should support variables
2 participants