Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing 1.0.0 I found this quality of life bug.
While using the dbt templater, if you're not careful with the path specification you could accidentally specify files explicitly in your dependencies which aren't actually rendered (as I found out in brooklyn-data/dbt_artifacts#125). I don't think it's a bug but it does currently result in a fatal
RuntimeError
if sqlfluff tries to lint a file which isn't found.I think this is the wrong behaviour and while we should still warn the user, the linting of the rest of the project should continue. Hence changing the error to
SQLTemplaterSkipFile
instead ofRuntimeError
.