Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L026: check standalone aliases as well as table aliases #3470

Merged

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #3341

Are there any other side effects of this change that we should be aware of?

Shouldn't be

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #3470 (14e34c9) into main (22de3dc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3470   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          171       171           
  Lines        12917     12921    +4     
=========================================
+ Hits         12917     12921    +4     
Impacted Files Coverage Δ
src/sqlfluff/rules/L026.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22de3dc...14e34c9. Read the comment docs.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I went off on a tangent with that other PR. 🤣

@barrywhart barrywhart merged commit fea2868 into sqlfluff:main Jun 20, 2022
@tunetheweb tunetheweb deleted the 3341-l026-check-standalonealiases branch June 23, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres: L026 rule violation for tables with function expression inside
2 participants