Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Remaining procedural statements #3473

Merged

Conversation

tunetheweb
Copy link
Member

Brief summary of the change made

Fixes #3461

Are there any other side effects of this change that we should be aware of?

No, but similar to previous nested statements with similar end blocks are not supported until #3345 is addressed

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #3473 (ec87ed6) into main (b347033) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #3473   +/-   ##
========================================
  Coverage   99.99%   100.00%           
========================================
  Files         171       171           
  Lines       12938     12979   +41     
========================================
+ Hits        12937     12979   +42     
+ Misses          1         0    -1     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_bigquery_keywords.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <100.00%> (ø)
src/sqlfluff/core/config.py 100.00% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b347033...ec87ed6. Read the comment docs.

@tunetheweb tunetheweb merged commit 9ec9acd into sqlfluff:main Jun 21, 2022
@tunetheweb tunetheweb deleted the 3461-bigquery-procedural-statements branch June 22, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Support for scripting statements REPEAT
2 participants