New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparkSQL: Update terminator grammar for HAVING
, WHERE
, GROUP BY
#3526
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3526 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 172
Lines 13073 13061 -12
=========================================
- Hits 13073 13061 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks could but could I ask for one addition? It may turn out to be a bit of effort so understand if you'd prefer to merge as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much code clean up - I love it!!
Brief summary of the change made
DISTRIBUTE BY
,CLUSTER BY
, andSORT BY
Are there any other side effects of this change that we should be aware of?
HAVING
for Snowflake, Ansi, and HiveGROUP BY
for Snowflake, Ansi, and HivePull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.