New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object Literals #3620
Object Literals #3620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you can fix the failing test cases
Some of the test failures are complaining about rule 48. Not sure why:
|
Codecov Report
@@ Coverage Diff @@
## main #3620 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 175 175
Lines 13255 13261 +6
=========================================
+ Hits 13255 13261 +6
Continue to review full report at Codecov.
|
This resolves #3606 .
Quite a few other things going on here though. The way that literals and expressions were being referenced wasn't very DRY, with many dialects redefining
LiteralGrammar
. In resolving some of those dependencies we also needed a better way of identifying offending grammars during debugging - so I've added acrumbs
keyword to simple, which catches infinite recursion early and outputs the offending loop. The magic for that is inRef
.Otherwise this is mostly the knockon effects of updating
LiteralGrammar
to include objects and then deduping elsewhere.