Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors for redundant definitions. #3626

Merged
merged 3 commits into from Jul 18, 2022
Merged

Conversation

alanmcruickshank
Copy link
Member

If we attempt to redefine a dialect element identically, this will now throw an error. It's another development safety net to catch some examples I've already removed.

I've added it with no cover because dialects are now clean, but tested it by adding some redundant definitions in and checking they throw errors.

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #3626 (0b58cd3) into main (6b31de4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3626   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          175       175           
  Lines        13261     13264    +3     
=========================================
+ Hits         13261     13264    +3     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_redshift.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_sparksql.py 100.00% <ø> (ø)
src/sqlfluff/core/dialects/base.py 100.00% <100.00%> (ø)
src/sqlfluff/core/parser/grammar/base.py 100.00% <100.00%> (ø)
src/sqlfluff/core/parser/grammar/delimited.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b31de4...0b58cd3. Read the comment docs.

@alanmcruickshank alanmcruickshank merged commit 655cc7f into main Jul 18, 2022
@alanmcruickshank alanmcruickshank deleted the ac/dialect_warning branch July 18, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants