Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate files before and during templating #3629

Merged
merged 10 commits into from Jul 23, 2022

Conversation

alanmcruickshank
Copy link
Member

This is related to debugging #3587 .

For some reason we're processing files twice in some circumstances. Re-processing a file using the dbt templater results in some tricky errors.

Before we attack the more complicated errors, we can do some things to more aggressively deduplicate at a few places in the process. This adds two of them.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #3629 (20cfba9) into main (011e195) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3629   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines        13326     13328    +2     
=========================================
+ Hits         13326     13328    +2     
Impacted Files Coverage Δ
src/sqlfluff/core/linter/linter.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011e195...20cfba9. Read the comment docs.

@alanmcruickshank alanmcruickshank marked this pull request as ready for review July 23, 2022 09:12
@alanmcruickshank alanmcruickshank merged commit 8e4f29e into main Jul 23, 2022
@alanmcruickshank alanmcruickshank deleted the ac/dbt_compiled_node branch July 23, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants