L057: In BigQuery, allow hyphens by default

[barrywhart]

Brief summary of the change made

Fixes #3638

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .yml rule test cases in test/fixtures/rules/std_rule_cases.
  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
  • Full autofix test cases in test/fixtures/linter/autofix.
  • Other.

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[barrywhart]

Minor bug fix: With Python configparser.ConfigParser, the class used to read this file, empty quotes don't return an empty string. They literally return the string "", which I believe is not what we want -- i.e., we don't want to allow " in names.

[codecov]

Codecov Report

Merging #3645 (3e736ed) into main (2c59a93) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3645   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          175       175           
  Lines        13286     13294    +8     
=========================================
+ Hits         13286     13294    +8     

Impacted Files	Coverage Δ
src/sqlfluff/rules/L057.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c59a93...3e736ed. Read the comment docs.

[tunetheweb]

Wonder if we should have a test without quotes?

[barrywhart]

I added another test case, test_pass_hyphen_bigquery_no_quotes, as you suggested. This was already "working" by accident, as we discussed on the related issue, so it's not related to the changes in this PR, but I agree it seems like a good test to prevent future breakage.