Add handling for Redshift CONVERT function data type argument
#3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3653 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 176 176
Lines 13328 13326 -2
=========================================
- Hits 13328 13326 -2
Continue to review full report at Codecov.
|
pdebelak
force-pushed
the
redshift-convert
branch
from
804c5d7
to
1695b0b
Compare
Fixes issue sqlfluff#3651. Previously, the first argument to the `convert` redshift function was interpreted as a column reference rather than a data type. This could cause rule L027 to fail since the data type wasn't qualified with a table name even though that doesn't make sense. This adds explicit handling for `convert` to eliminate that issue.
pdebelak
force-pushed
the
redshift-convert
branch
from
1695b0b
to
a29aa51
Compare
tunetheweb
approved these changes
Jul 23, 2022
tunetheweb
changed the title
CONVERT function data type argument
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes issue #3651.
Previously, the first argument to the
convertredshift function was interpreted as a column reference rather than a data type. This could cause rule L027 to fail since the data type wasn't qualified with a table name even though that doesn't make sense. This adds explicit handling forconvertto eliminate that issue.Are there any other side effects of this change that we should be aware of?
Not that I'm aware of.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.