Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set issue dialect labels via Github Actions #3666

Merged
merged 1 commit into from Jul 25, 2022

Conversation

greg-finley
Copy link
Contributor

Brief summary of the change made

Closes #3665

See the auto-labeled issues in my fork: https://github.com/greg-finley/sqlfluff/issues

Are there any other side effects of this change that we should be aware of?

No. Maybe it should search issue body also, but searching only the title seems to have less false positives.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3666 (cff0b28) into main (39c3fe6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3666   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines        13359     13359           
=========================================
  Hits         13359     13359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c3fe6...cff0b28. Read the comment docs.

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alanmcruickshank alanmcruickshank merged commit 2292816 into sqlfluff:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label dialect bugs automatically based on issue title
2 participants