Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T-SQL: Parse DATEPART date type as date type instead of column name #3681

Merged
merged 4 commits into from Jul 27, 2022
Merged

T-SQL: Parse DATEPART date type as date type instead of column name #3681

merged 4 commits into from Jul 27, 2022

Conversation

borchero
Copy link
Contributor

Brief summary of the change made

Resolves #3630.

Are there any other side effects of this change that we should be aware of?

n/a

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@greg-finley greg-finley changed the title [T-SQL] Parse DATEPART date type as date type instead of column name T-SQL: Parse DATEPART date type as date type instead of column name Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #3681 (fa1e0f6) into main (7a40bf6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3681   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines        13359     13359           
=========================================
  Hits         13359     13359           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_tsql.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a40bf6...fa1e0f6. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@greg-finley greg-finley merged commit 3030af7 into sqlfluff:main Jul 27, 2022
@borchero borchero deleted the fix-datepart branch July 27, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSQL: function DATEPART: date type is parsed as column identifier
3 participants