Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T-SQL: Properly parse collation names #3686

Merged
merged 2 commits into from Jul 29, 2022
Merged

T-SQL: Properly parse collation names #3686

merged 2 commits into from Jul 29, 2022

Conversation

borchero
Copy link
Contributor

@borchero borchero commented Jul 28, 2022

Brief summary of the change made

The main branch of SQLFluff currently parses collation names appearing in COLLATE expressions as column identifiers. For example, the following SQL ...

SELECT table1.col COLLATE Latin1_General_CI_AS
FROM table1;

... generates the following errors with dialect tsql:

L:   1 | P:  27 | L014 | Unquoted identifiers must be consistently lower case.                                                                      
L:   1 | P:  27 | L028 | Unqualified reference 'Latin1_General_CI_AS' found in
                       | single table select.
L:   1 | P:  27 | L028 | Unqualified reference 'Latin1_General_CI_AS' found in
                       | single table select which is inconsistent with previous
                       | references.

Instead, we want to parse the collation as dedicated identifier "collation". This PR causes the above SQL query to be linted without errors.

Are there any other side effects of this change that we should be aware of?

Probably not, but I did modify Expression_A_Grammar. Should be checked carefully.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #3686 (eda7cb4) into main (7cd64c7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3686   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines        13359     13363    +4     
=========================================
+ Hits         13359     13363    +4     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_tsql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd64c7...eda7cb4. Read the comment docs.

Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution.

@greg-finley greg-finley merged commit 1a7a562 into sqlfluff:main Jul 29, 2022
@borchero borchero deleted the fix-collate-unqualified-reference branch July 29, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants