Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current_timestamp to Redshift as a bare function #3741

Merged
merged 2 commits into from Aug 15, 2022

Conversation

RossOkuno
Copy link
Contributor

@RossOkuno RossOkuno commented Aug 15, 2022

Brief summary of the change made

This PR is to allow current_timestamp without parenthesis in Redshift.
Fixes #3573

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@RossOkuno RossOkuno marked this pull request as ready for review August 15, 2022 06:03
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #3741 (b94f0d6) into main (bc14733) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          176       176           
  Lines        13466     13466           
=========================================
  Hits         13466     13466           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_redshift.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit 40f3d81 into sqlfluff:main Aug 15, 2022
@RossOkuno RossOkuno deleted the add_current_timestamp_redshift branch August 15, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse error on redshift current_timestamp
2 participants