New rule L069: Consistent syntax for sql type casting

[bolajiwahab]

Brief summary of the change made

Fixes #3713

Are there any other side effects of this change that we should be aware of?

Had to regenerate all fixtures that included cast_expression.

Pull Request checklist

• Please confirm you have completed any of the necessary steps below.

• Included test cases to demonstrate any code changes, which may be one or more of the following:

  • .yml rule test cases in test/fixtures/rules/std_rule_cases.
  • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
  • Full autofix test cases in test/fixtures/linter/autofix.
  • Other.

• Added appropriate documentation for the change.

• Created GitHub issues for any relevant followup/future enhancements if appropriate.

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5d30c05) compared to base (f4b51b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##              main     #3747    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          190       191     +1     
  Lines        14591     14718   +127     
==========================================
+ Hits         14591     14718   +127     

Impacted Files	Coverage Δ
src/sqlfluff/core/rules/config_info.py	100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_ansi.py	100.00% <ø> (ø)
src/sqlfluff/rules/L034.py	100.00% <ø> (ø)
src/sqlfluff/rules/L013.py	100.00% <100.00%> (ø)
src/sqlfluff/rules/L069.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bolajiwahab]

@barrywhart and @alanmcruickshank if you have some spare time, can you review this PR? Thanks

[barrywhart]

Thanks for letting me know. There's no pressure, I was just looking over the list of PRs yesterday and was curious. 🙏

[bolajiwahab]

Thanks for letting me know. There's no pressure, I was just looking over the list of PRs yesterday and was curious. 🙏

Been quite hung up with a few things. I will find time this weekend to finish it up.

[barrywhart]

A few lines of the rule are not covered by the tests. If it's reasonable to test those, that's good. If not, we add # pragma: no coverto get the coverage check to pass.

[bolajiwahab]

A few lines of the rule are not covered by the tests. If it's reasonable to test those, that's good. If not, we add # pragma: no coverto get the coverage check to pass.

Yeah, looking into those.

[bolajiwahab]

@barrywhart You may review the PR now. Thank you.

[barrywhart]

@OTooleMichael: You had requested changes on this PR. Can you review it again?

@tunetheweb: Can you please review the small dialect change to this PR?

Many changes since then, asked him to review again but haven't heard back

[tunetheweb]

LGTM!