Add a file size check in bytes #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3770 +/- ##
========================================
Coverage 99.99% 100.00%
========================================
Files 179 179
Lines 13681 13699 +18
========================================
+ Hits 13680 13699 +19
+ Misses 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
barrywhart
reviewed
Aug 22, 2022
barrywhart
approved these changes
Aug 22, 2022
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3693.
Is adds another config flag (
large_file_skip_byte_limit) which checks the size of the file in bytes before loading it. Very similar functionality tolarge_file_skip_char_limit.I've kept the original config flag but changed the default so that it's not applied. If anyone is still using it - it will work but they'll get a deprecation warning, point them to the new flag which should be much more efficient. In a future release we can remove the old flag.
In the process I also rename
SQLTemplaterSkipFiletoSQLFluffSkipFile- because we're not just calling it from the templater anymore - and there's nothing particularly templater specific about it.