Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: CREATE FUNCTION IF NOT EXISTS #3845

Merged

Conversation

greg-finley
Copy link
Contributor

Brief summary of the change made

Closes #3844

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link

@janovergoor janovergoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for the quick turn-around

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #3845 (384addd) into main (afec099) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #3845   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        13729     13729           
=========================================
  Hits         13729     13729           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@barrywhart barrywhart merged commit 1000cf1 into sqlfluff:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake: Parsing Error for CREATE FUNCTION IF NOT EXISTS
3 participants