Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: AlterShareStatementSegment and CreateDatabaseFromShareStatementSegment #3858

Conversation

moreaupascal56
Copy link
Contributor

@moreaupascal56 moreaupascal56 commented Sep 20, 2022

Brief summary of the change made

Addition of support for "ALTER SHARE" queries (snowflake doc) and "CREATE DATABASE FROM SHARE" (snowflake doc) with appropriated tests.

makes progress on #3479

Are there any other side effects of this change that we should be aware of?

no

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@greg-finley greg-finley changed the title Additions in snowflake dialect: AlterShareStatementSegment and CreateDatabaseFromShareStatementSegment Snowflake: AlterShareStatementSegment and CreateDatabaseFromShareStatementSegment Sep 22, 2022
Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ff3c7ac) compared to base (768e6f5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #3858   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        13772     13778    +6     
=========================================
+ Hits         13772     13778    +6     
Impacted Files Coverage Δ
...rc/sqlfluff/dialects/dialect_snowflake_keywords.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@greg-finley greg-finley merged commit 011644c into sqlfluff:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants