MySQL: Support column-path operator for JSON type #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoichi
force-pushed
the
mysql-json-column-path
branch
from
092e5b3
to
ff7df33
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #3864 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 13779 13782 +3
=========================================
+ Hits 13779 13782 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
barrywhart
reviewed
Sep 24, 2022
| @@ -2333,3 +2360,23 @@ class DropTriggerStatementSegment(ansi.DropTriggerStatementSegment): | |||
| Ref("IfExistsGrammar", optional=True), | |||
| Ref("TriggerReferenceSegment"), | |||
| ) | |||
|
|
|||
|
|
|||
| class ColumnReferenceSegment(ansi.ColumnReferenceSegment): | |||
There was a problem hiding this comment.
Since this is unusual syntax, could you add a link to the MySQL documentation for this?
There was a problem hiding this comment.
Thanks. Added in d0fc8f0
greg-finley
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
fixes #3863
Are there any other side effects of this change that we should be aware of?
no
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.