Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw_segments_with_ancestors #3878

Merged
merged 3 commits into from
Sep 25, 2022
Merged

Conversation

alanmcruickshank
Copy link
Member

This is another relatively standalone part of #3824.

It's slightly more abstract than the others as nothing in the codebase uses the method yet, but it is well tested, and takes a little more logic out of the parent PR to make that more manageable.

This has already been partly reviewed by @barrywhart as part of the original PR so should look familiar.

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (65fa5be) compared to base (14033f7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #3878   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        13811     13820    +9     
=========================================
+ Hits         13811     13820    +9     
Impacted Files Coverage Δ
src/sqlfluff/core/parser/segments/base.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@barrywhart barrywhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Not merging yet because update/CI build is still in progress.

@alanmcruickshank
Copy link
Member Author

Actually - hold off on merging - there's another commit that needs to be added here 🤦 .

@alanmcruickshank
Copy link
Member Author

alanmcruickshank commented Sep 25, 2022

There we go! Juggling too many branches. That was my fault. Ready to merge at will now.

It just changes the return type to a list of PathStep - in line with the changes to .path_to().

@alanmcruickshank alanmcruickshank merged commit 388dd01 into main Sep 25, 2022
@alanmcruickshank alanmcruickshank deleted the ac/raw_segments_ancestors branch September 25, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants