Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better file not found error #1023 #4051

Merged
merged 2 commits into from Nov 10, 2022
Merged

Better file not found error #1023 #4051

merged 2 commits into from Nov 10, 2022

Conversation

alanmcruickshank
Copy link
Member

This resolves #1023 (an oldie).

It also actually allows us to simplify the code by emitting a SQLFluffUserError directly rather than an OSError and then needing to do guesswork around that.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 61.15% // Head: 99.93% // Increases project coverage by +38.78% 🎉

Coverage data is based on head (1547698) compared to base (c3defb0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4051       +/-   ##
===========================================
+ Coverage   61.15%   99.93%   +38.78%     
===========================================
  Files         190      190               
  Lines       14556    14570       +14     
===========================================
+ Hits         8901    14561     +5660     
+ Misses       5655        9     -5646     
Impacted Files Coverage Δ
src/sqlfluff/cli/commands.py 100.00% <100.00%> (+55.72%) ⬆️
src/sqlfluff/core/linter/linter.py 100.00% <100.00%> (+25.05%) ⬆️
src/sqlfluff/core/parser/parsers.py 100.00% <0.00%> (+2.40%) ⬆️
src/sqlfluff/dialects/dialect_ansi.py 100.00% <0.00%> (+2.54%) ⬆️
src/sqlfluff/rules/L045.py 100.00% <0.00%> (+3.03%) ⬆️
src/sqlfluff/rules/L063.py 100.00% <0.00%> (+3.22%) ⬆️
src/sqlfluff/core/parser/segments/ephemeral.py 100.00% <0.00%> (+3.44%) ⬆️
src/sqlfluff/rules/L050.py 100.00% <0.00%> (+3.70%) ⬆️
src/sqlfluff/core/dialects/base.py 100.00% <0.00%> (+3.84%) ⬆️
src/sqlfluff/dialects/dialect_postgres_keywords.py 100.00% <0.00%> (+4.00%) ⬆️
... and 139 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alanmcruickshank alanmcruickshank merged commit 5e26887 into main Nov 10, 2022
@alanmcruickshank alanmcruickshank deleted the ac/path_error branch November 10, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading path does not exist message
2 participants