Fix bug where L034 should ignore INSERT or "CREATE TABLE AS SELECT" with CTE #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrywhart
requested review from
alanmcruickshank,
tunetheweb and
greg-finley
tunetheweb
approved these changes
Nov 25, 2022
| @@ -94,10 +94,24 @@ def _eval(self, context: RuleContext) -> EvalResultType: | |||
| "insert_statement", "set_expression" | |||
| ): | |||
| return None | |||
| if ( | |||
| len(context.parent_stack) >= 3 | |||
| and context.parent_stack[-3].is_type("insert_statement", "set_expression") | |||
There was a problem hiding this comment.
Should you have a set_expression test case?
There was a problem hiding this comment.
I tried to create one, but couldn't get it to parse.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 193 193
Lines 14806 14810 +4
=========================================
+ Hits 14806 14810 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #4105
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.