SparkSQL: Mark AS as optional keyword for CTE & CTS
#4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulixius9
changed the title
AS as optional keyword for CTEAS as optional keyword for CTE & CTS
greg-finley
reviewed
Dec 2, 2022
test/fixtures/dialects/sparksql/with_insert_with_statement_a.sql
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 195 195
Lines 14920 14920
=========================================
Hits 14920 14920
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
greg-finley
reviewed
Dec 8, 2022
greg-finley
approved these changes
Dec 9, 2022
|
Could you run the |
barrywhart
reviewed
Dec 10, 2022
Co-authored-by: Barry Hart <barrywhart@yahoo.com>
barrywhart
reviewed
Dec 10, 2022
barrywhart
reviewed
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.