Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB2] Fix parsing of string identifiers #4134

Merged
merged 3 commits into from Dec 9, 2022
Merged

[DB2] Fix parsing of string identifiers #4134

merged 3 commits into from Dec 9, 2022

Conversation

borchero
Copy link
Contributor

@borchero borchero commented Dec 2, 2022

Brief summary of the change made

Fixes #4133.

Are there any other side effects of this change that we should be aware of?

n/a

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6c21775) compared to base (5364c7e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        14922     14922           
=========================================
  Hits         14922     14922           
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_db2.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@greg-finley greg-finley merged commit 1c50eec into sqlfluff:main Dec 9, 2022
@borchero borchero deleted the fix-db2 branch December 9, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db2 dialect throws errors with strings
2 participants