Fix #4252 (Resolve multiple sensible indents) #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3925631069
💛 - Coveralls |
| FROM table | ||
| WHERE | ||
| NOT bool_column AND NOT bool_column | ||
| AND some_column >= 1 |
There was a problem hiding this comment.
This doesn't have a comment in it?
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4285 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 201 201
Lines 15176 15181 +5
=========================================
+ Hits 15176 15181 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #4252.
The issue arises from a bug in #4239. That PR did not account for both the point before and after the comment having important indent stats. This introduces a method for combining them so all the information is encoded.