New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Databricks as a distinct dialect #4438
Conversation
Pull Request Test Coverage Report for Build 4286916548
💛 - Coveralls |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4438 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 206 208 +2
Lines 15408 15417 +9
=========================================
+ Hits 15408 15417 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. If there are differences between the two - then it's a good idea to split them. Still makes sense for one to depend on the other though 👍
Brief summary of the change made
This separates out Databricks as its own dialect. For now, it just changes the keyword distribution between reserved and unreserved, but we may want to move the databricks-specific stuff in a non-back-compatible way for 2.0
Fixes #4266
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.