Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Databricks as a distinct dialect #4438

Merged
merged 6 commits into from Feb 27, 2023
Merged

Conversation

WittierDinosaur
Copy link
Contributor

Brief summary of the change made

This separates out Databricks as its own dialect. For now, it just changes the keyword distribution between reserved and unreserved, but we may want to move the databricks-specific stuff in a non-back-compatible way for 2.0
Fixes #4266

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@coveralls
Copy link

coveralls commented Feb 27, 2023

Pull Request Test Coverage Report for Build 4286916548

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4285501323: 0.0%
Covered Lines: 17253
Relevant Lines: 17253

💛 - Coveralls

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (2f4001e) compared to base (b600627).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4438   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       208    +2     
  Lines        15408     15417    +9     
=========================================
+ Hits         15408     15417    +9     
Impacted Files Coverage Δ
src/sqlfluff/core/dialects/__init__.py 100.00% <ø> (ø)
src/sqlfluff/rules/L064.py 100.00% <ø> (ø)
src/sqlfluff/rules/capitalisation/CP02.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_databricks.py 100.00% <100.00%> (ø)
...c/sqlfluff/dialects/dialect_databricks_keywords.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/L026.py 100.00% <100.00%> (ø)
src/sqlfluff/rules/L057.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. If there are differences between the two - then it's a good idea to split them. Still makes sense for one to depend on the other though 👍

@alanmcruickshank alanmcruickshank enabled auto-merge (squash) February 27, 2023 21:17
@alanmcruickshank alanmcruickshank merged commit 009725c into main Feb 27, 2023
@alanmcruickshank alanmcruickshank deleted the dialect-databricks branch February 27, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found unparsable section: '.order'
3 participants