New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teradata: Added "AND STATS" options when creating table #4440
Conversation
Fixes to resolve: sqlfluff#4436 - Updated keywords list with STATS - Applied change to ensure that AND STATS options are available - Added test cases to create_table_with_data.sql file - regenerated corresponding YAML file and checked output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
@dflem97 Thanks for the contribution! Could you please check the linting failures from the CI pipeline? Thanks. 🙂 |
Pull Request Test Coverage Report for Build 4290591541
💛 - Coveralls |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4440 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 208 208
Lines 15417 15417
=========================================
Hits 15417 15417
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Changed formatting to pass linting test
Head branch was pushed to by a user without write access
thanks @greg-finley |
Brief summary of the change made
Fixes #4436
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.