References rule bundle #4446
Merged
References rule bundle #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4307518570
💛 - Coveralls |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4446 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 210 212 +2
Lines 15473 15497 +24
=========================================
+ Hits 15473 15497 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alanmcruickshank
changed the title
pwildenhain
approved these changes
Mar 1, 2023
| @@ -281,7 +281,7 @@ require_final_semicolon = False | |||
| # GROUP BY/ORDER BY column references | |||
| group_by_and_order_by_style = consistent | |||
|
|
|||
| [sqlfluff:rules:L057] | |||
| [sqlfluff:rules:RF05] | |||
There was a problem hiding this comment.
Are there any plans to allow using the new "readable" rule names in the config rather than the codes?
There was a problem hiding this comment.
I'll slack you about this. Short answer - not at the moment because if we accept more than one way of specifying config, we then have to deal with resolving priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step in #4031. These ones are all straightforward recodes. All the rules are still intact and just moved into new bundles as per the rules spreadsheet.
The only deeper functionality change here is the RF04, RF05 and CP02 shared a utility function called
identifiers_policy_applicablewhich had been living in thecapitalisationbundle. With the new plugin structure, having bundles which depend on other bundles doesn't work neatly (and results in circular imports). To resolve that I've mode this method into thesqlfluff.utilmodule so that both can depend on it neatly.