Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensions and plugin section to the README.md #4454

Conversation

jared-rimmer
Copy link
Contributor

@jared-rimmer jared-rimmer commented Mar 2, 2023

Brief summary of the change made

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

README.md Outdated

And an IntelliJ Plugin:

- [Github Repository](https://github.com/anboralabs/sqlfluff-intellij-community)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be advertising this. I've tried it, and don't think it's very good. It's also not an official SQLFluff plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I have removed it in a new commit.

@coveralls
Copy link

coveralls commented Mar 2, 2023

Pull Request Test Coverage Report for Build 4313314415

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4308900735: 0.0%
Covered Lines: 17376
Relevant Lines: 17376

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a4d24c) 100.00% compared to head (4e61b6d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4454   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          213       213           
  Lines        15534     15534           
=========================================
  Hits         15534     15534           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur merged commit a90c683 into sqlfluff:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document extensions
3 participants