Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config documentation #452

Merged
merged 4 commits into from Oct 1, 2020
Merged

Improve config documentation #452

merged 4 commits into from Oct 1, 2020

Conversation

pwildenhain
Copy link
Member

Closes #423

@pwildenhain pwildenhain added the documentation Add or improve documentation (including error messages) label Oct 1, 2020
@pwildenhain pwildenhain self-assigned this Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020 •
edited

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          30       30           
  Lines        4633     4633           
=======================================
  Hits         4250     4250           
  Misses        383      383
Flag Coverage Δ
#py35 91.59% <ø> (ø)
#py36 91.59% <ø> (ø)
#py37 91.59% <ø> (ø)
#py38 91.55% <ø> (ø)
#py39 91.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49938e...27935a9. Read the comment docs.

alanmcruickshank
alanmcruickshank approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 👍

@alanmcruickshank alanmcruickshank merged commit fc93ee2 into master Oct 1, 2020
@pwildenhain pwildenhain added this to In progress in Major Release: 0.4.0 Oct 3, 2020
@pwildenhain pwildenhain removed this from In progress in Major Release: 0.4.0 Oct 3, 2020
@pwildenhain pwildenhain deleted the pw/docs/add-info-about-default-cli-args branch November 22, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees

@pwildenhain pwildenhain

Labels
documentation Add or improve documentation (including error messages)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain .sqlfluff config options more clearly in the config docs
2 participants
@pwildenhain @alanmcruickshank